search

qmarcou / IGoR

IGoR is a C++ software designed to infer V(D)J recombination related processes from sequencing data. Find full documentation at:
https://qmarcou.github.io/IGoR/
GNU General Public License v3.0
47 stars 25 forks source link

Pygor - Small fix bestscenarios #26

Closed penuts7644 closed 5 years ago

penuts7644 commented 5 years ago

Small fix for bestscenarios: 'DinucMarkov' numpy arrays are not converting to lists properly when they are export to a CSV file from the pandas dataframe. Comma separators are removed in such scenario and some of the rows have double quotation marks randomly positioned in the row.

penuts7644 commented 5 years ago

Btw Quentin, I know we have discussed this before, but is it ok if I look into making pygor accessible via Pypi. I need to use some of its code on a server that only allows installs via Pypi. In that case I would also be happy to help out a bit more on pygor's code base :) Cheers, Wout

qmarcou commented 5 years ago

Hey Wout! Thanks for the fix I'll have a look at it soon! My only problem with PyPi is that I actually don't know how much overhead it would be to maintain the package there, and pygor is not such a big piece. That being said I think if the Pypi package page links to this repository and makes explicit the fact that the Pypi may not be the latest version and that Pygor is officially maintained here it could be a could idea! Concerning the development of pygor itself, maybe I'll open a dedicated issue for it so we can discuss it with more visibility Cheers, Quentin

penuts7644 commented 5 years ago

Hi Quentin, Opening a new issue for it sounds like a great! I'll be happy to help out, also regarding maintaining the pygor. Currently for my thesis, I'm creating some small tools that could eventually even be added to pygor. (mostly because it uses pygor and IGoR's models) (URL to the repo: https://github.com/penuts7644/TcrDataComparison) Cheers, Wout