fix: preventDefault and stopPropagation should be called before await

quadratichq / quadratic

Quadratic | Technical Spreadsheet with Python, SQL, and AI

https://QuadraticHQ.com

Other

2.8k stars 140 forks source link

Closed AyushAgrawal-A2 closed 5 days ago

AyushAgrawal-A2 commented 1 week ago

closes #1453

Changes

Moved event.stopPropagation and event.preventDefault before await fn call.
Also, I believe it is good practice to call these first before running any internal code. I have moved all occurrences of these to the top of executing code without changing functional logic.

vercel[bot] commented 1 week ago

@AyushAgrawal-A2 is attempting to deploy a commit to the Quadratic Team on Vercel.

A member of the Team first needs to authorize it.

davidfig commented 6 days ago

Please resolve conflict @AyushAgrawal-A2

AyushAgrawal-A2 commented 5 days ago

Please resolve conflict @AyushAgrawal-A2

@davidfig Done