search

quadratichq / quadratic

Quadratic | Technical Spreadsheet with Python, SQL, and AI
https://QuadraticHQ.com
Other
2.8k stars 140 forks source link

fix bug with cmd+clicking the first cell in a boxed selection #1479

Closed davidfig closed 6 days ago

davidfig commented 6 days ago

Fixes #1478

To replicate:

  1. select multiple cells
  2. click cmd+click on the top-left cell

old behavior: crashes b/c of an exception new behavior: properly selects that cell

Ideal behavior: unselects that cell (but this will require work)

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Jun 26, 2024 10:08pm
codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.54%. Comparing base (8805288) to head (adc5bc9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1479 +/- ## ======================================= Coverage 90.54% 90.54% ======================================= Files 178 178 Lines 32966 32966 ======================================= Hits 29849 29849 Misses 3117 3117 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.