search

quadratichq / quadratic

Quadratic | Spreadsheet with Python, SQL, and AI
https://QuadraticHQ.com
Other
2.99k stars 151 forks source link

Code selector is inaccessible in Firefox #1499

Closed HactarCE closed 2 months ago

HactarCE commented 3 months ago

Pressing / to open the code selector also opens "quick-find" in Firefox. The first time it's pressed, it opens the code selector and the quick-find, but focuses the quick-find popup, which removes focus from the grid and causes subsequent keystrokes to be lost. This is particularly devious because quick-find is so subtle at the bottom of the screen, so just seems like the keyboard stops working after pressing /.

I believe this is a significant accessibility issue, since I can't find any other way to open the code selector.

Actions we need to take:

davidkircos commented 3 months ago

This may be because the function is called async here https://github.com/quadratichq/quadratic/blob/f1926e9aa6feb11a2b7f5297fac8974e1253de2e/quadratic-client/src/app/gridGL/interaction/keyboard/keyboardCell.ts#L29

I believe to prevent default we need to have this function be synchronous

ghislainp commented 1 month ago

Pressing / just open the quick find in firefox on Linux. It does not open the code selector. (I'm on a French keyboard where / is accessible through SHIFT only).

davidkircos commented 1 month ago

Pressing / just open the quick find in firefox on Linux. It does not open the code selector. (I'm on a French keyboard where / is accessible through SHIFT only).

Hello @ghislainp thanks for the feedback, we are going to make it so that Shift + / also opens the code selector menu.

https://github.com/quadratichq/quadratic/pull/1801