quadratichq / quadratic

Quadratic | Spreadsheet with Python, SQL, and AI
https://QuadraticHQ.com
Other
3.05k stars 157 forks source link

Cells accessed refactor #1968

Closed davidfig closed 2 weeks ago

davidfig commented 1 month ago

This is a working branch from remove_negative_2 that refactors CellsAccessed to use A1RangeType. It's separated for ease of review and to ensure compatibility with the tables branch.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ❌ Failed (Inspect) Nov 16, 2024 5:18pm
qa-wolf[bot] commented 1 month ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 84.94898% with 177 lines in your changes missing coverage. Please review.

Please upload report for BASE (remove-negative-2@f0495d4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...uadratic-core/src/grid/file/serialize/code_cell.rs 81.62% 61 Missing :warning:
quadratic-core/src/grid/code_run.rs 12.00% 22 Missing :warning:
quadratic-core/src/grid/cells_accessed.rs 87.50% 21 Missing :warning:
...er/execution/execute_operation/execute_col_rows.rs 28.57% 15 Missing :warning:
quadratic-core/src/a1/a1_error.rs 25.00% 12 Missing :warning:
...roller/execution/execute_operation/execute_code.rs 54.16% 11 Missing :warning:
...dratic-core/src/controller/operations/operation.rs 0.00% 9 Missing :warning:
quadratic-core/src/a1/a1_range/mod.rs 92.66% 8 Missing :warning:
quadratic-core/src/grid/sheet/sheet_a1.rs 92.20% 6 Missing :warning:
quadratic-core/src/grid/file/sheet_schema.rs 0.00% 4 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## remove-negative-2 #1968 +/- ## ==================================================== Coverage ? 90.92% ==================================================== Files ? 266 Lines ? 58523 Branches ? 0 ==================================================== Hits ? 53211 Misses ? 5312 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.