quadratichq / quadratic

Quadratic | Spreadsheet with Python, SQL, and AI
https://QuadraticHQ.com
Other
3.05k stars 157 forks source link

fix: inline editor arrow key interactions (edit & enter states) #1972

Closed AyushAgrawal-A2 closed 1 week ago

AyushAgrawal-A2 commented 1 month ago

closes #1961

Mode indicator: (for testing, will change) Insert Cell Ref Mode: White Icon image

Navigate Text Mode: Black Icon image

qa-wolf[bot] commented 1 month ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ❌ Failed (Inspect) Nov 21, 2024 5:05pm
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.82%. Comparing base (51156b2) to head (5378d8b). Report is 43 commits behind head on qa.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## qa #1972 +/- ## ========================================== - Coverage 93.06% 90.82% -2.24% ========================================== Files 215 260 +45 Lines 54353 57549 +3196 ========================================== + Hits 50581 52271 +1690 - Misses 3772 5278 +1506 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

AyushAgrawal-A2 commented 1 week ago

Can we provide some spacing/padding around the icon? For example, this this screenshot, the icon size is 15x15px (instead of 20x20). Gives it a little more space to breathe.

CleanShot 2024-11-20 at 11 09 33@2x

@jimniels done