quadratichq / quadratic

Quadratic | Spreadsheet with Python, SQL, and AI
https://QuadraticHQ.com
Other
3.05k stars 157 forks source link

feat: user selectable csv delimiter #1975

Open AyushAgrawal-A2 opened 1 month ago

AyushAgrawal-A2 commented 1 month ago

ref: https://github.com/quadratichq/quadratic/issues/1965

Changes:

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Nov 6, 2024 1:43am
qa-wolf[bot] commented 1 month ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 39.59538% with 209 lines in your changes missing coverage. Please review.

Project coverage is 90.71%. Comparing base (abe2883) to head (39b9798). Report is 329 commits behind head on data-tables-v1.

Files with missing lines Patch % Lines
quadratic-rust-shared/src/storage/file_system.rs 0.00% 53 Missing :warning:
quadratic-rust-shared/src/crypto/aes_cbc.rs 0.00% 31 Missing :warning:
quadratic-rust-shared/src/storage/s3.rs 0.00% 31 Missing :warning:
quadratic-rust-shared/src/storage/mod.rs 0.00% 26 Missing :warning:
quadratic-rust-shared/src/sql/mssql_connection.rs 0.00% 16 Missing :warning:
...adratic-rust-shared/src/sql/postgres_connection.rs 0.00% 9 Missing :warning:
quadratic-core/src/controller/operations/import.rs 91.66% 8 Missing :warning:
quadratic-rust-shared/src/error.rs 0.00% 8 Missing :warning:
quadratic-rust-shared/src/sql/mysql_connection.rs 0.00% 8 Missing :warning:
...dratic-rust-shared/src/sql/snowflake_connection.rs 0.00% 6 Missing :warning:
... and 9 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## data-tables-v1 #1975 +/- ## ================================================== - Coverage 90.96% 90.71% -0.25% ================================================== Files 250 260 +10 Lines 56531 56796 +265 ================================================== + Hits 51422 51523 +101 - Misses 5109 5273 +164 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

AyushAgrawal-A2 commented 1 month ago

Any opposition to bringing in these changes?

nope, also you don't need to ask