quadratichq / quadratic

Quadratic | Spreadsheet with Python, SQL, and AI
https://QuadraticHQ.com
Other
3.05k stars 157 forks source link

fix: dirty_hashes for change_spill #1985

Closed AyushAgrawal-A2 closed 3 weeks ago

AyushAgrawal-A2 commented 1 month ago

file: Untitled.zip

before:

https://github.com/user-attachments/assets/e2cf3d06-03af-40d5-89e8-a47ff60d62df

after:

https://github.com/user-attachments/assets/cb1de4cf-95eb-4447-8d26-59e397ab2511

qa-wolf[bot] commented 1 month ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Oct 22, 2024 6:45pm
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.96%. Comparing base (abe2883) to head (9ac106d). Report is 187 commits behind head on qa.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## qa #1985 +/- ## ======================================= Coverage 90.96% 90.96% ======================================= Files 250 250 Lines 56531 56530 -1 ======================================= Hits 51422 51422 + Misses 5109 5108 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

qa-wolf[bot] commented 3 weeks ago

E2E tests

Running Status Preview Started Run time Est. dev time saved
83 workflows In review (Details) Nov 6, 2024 at 12:39 AM (UTC)
⚠️ 70 failed - your wolf pack is investigating
✅ 3 passed

Preexisting bugs

3 Blocking bugs
If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs

1 Non-blocking bug