quadratichq / quadratic

Quadratic | Spreadsheet with Python, SQL, and AI
https://QuadraticHQ.com
Other
3.04k stars 155 forks source link

feat: request proxying for JS & fix auth header override for both JS and Python requests #2083

Closed AyushAgrawal-A2 closed 4 days ago

AyushAgrawal-A2 commented 5 days ago

closes #1899 closes #1785

qa-wolf[bot] commented 5 days ago

QA Wolf here! As you write new code it's important that your test coverage is keeping up. Click here to request test coverage for this PR!

vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Nov 19, 2024 8:55pm
codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.82%. Comparing base (ba07e0c) to head (f0b1f83). Report is 17 commits behind head on qa.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## qa #2083 +/- ## ======================================= Coverage 90.82% 90.82% ======================================= Files 260 260 Lines 57546 57546 ======================================= Hits 52269 52269 Misses 5277 5277 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

ddimaria commented 4 days ago

This patch works, but does not close #1785 as it doesn't conform to the design:

In the client, pack all user-defined headers into a body var called user-headers

This design will avoid future collisions.

ddimaria commented 4 days ago

This patch works, but does not close #1785 as it doesn't conform to the design:

In the client, pack all user-defined headers into a body var called user-headers

This design will avoid future collisions.

@AyushAgrawal-A2 After reviewing again, I think the prefix approach works. Let me know when the other comments are addressed and I'll re-review.