feat: keyboard shorctut menus and readability

quadratichq / quadratic

Quadratic | Technical Spreadsheet with Python, SQL, and AI

https://QuadraticHQ.com

Other

2.92k stars 148 forks source link

feat: keyboard shorctut menus and readability #312

Open jimniels opened 1 year ago

jimniels commented 1 year ago

Current problems:

Keyboard shortcuts are defined in multiple places in the code, so if you change a shortcut in one place, you can't forget to do it elsewhere. We should have one universal mapping of shortcuts
Shortcuts need better style for readability, especially on windows, e.g. shortcuts like "⌘." can be hard to read and even more so for windows users who will see "Ctrl." We should consider separating commands and using a monospace font, e.g. ⌘ + .

jimniels commented 1 year ago

Also: we should remove shortcuts from menus on mobile

jimniels commented 1 year ago

Additional consideration for any new design: keyboard shortcuts can appear in lots of different contexts: like on menus, the command palette, and even on black backgrounds like on Snackbar components

jimniels commented 1 year ago

We should have a globally-accessible way for users to discover what the keyboard shortcuts are

Figma (control + shift + ?):

Sheets (CMD + /):

jimniels commented 1 year ago

Should shortcuts show up on mobile devices? Conceivably, a device like an iPad (or even an iPhone, really) could be hooked up to a bluethooth keyboard and therefore shortcuts would be useful