search

quarto-dev / quarto-cli

Open-source scientific and technical publishing system built on Pandoc.
https://quarto.org
Other
3.57k stars 293 forks source link

Book 404 page does not include book navbar preventing navigation #10014

Open cderv opened 3 weeks ago

cderv commented 3 weeks ago

Discussed in https://github.com/quarto-dev/quarto-cli/discussions/9988

Originally posted by **meierluk** June 13, 2024 ### Description It would be nice if a custom 404.qmd would automatically inherit all the properties of the corresponding book project, i.e., render with the navbar etc. (as seems to have been the case with bookdown).

From https://github.com/quarto-dev/quarto-cli/discussions/9988#discussioncomment-9763030

If I use the (only-slightly edited) book template, I get this 404.html, compare with the standard book layout.

The source is available on github.com/meierluk/quarto-test/.

cderv commented 3 weeks ago

I can confirm that this is same issue as others we have. The commit which breaks this is https://github.com/quarto-dev/quarto-cli/commit/ff820aa32f00f0a5cc3f59598c660da945f6707c with the change regarding sidebar

Same cause than

which were supposed to be solved by

But it was not a good fix as it broke complex website

So still ongoing work at

Our global sidebar logic seems to be broken, and only pages identified in sidebars gets one.