quarto-dev / quarto-cli

Open-source scientific and technical publishing system built on Pandoc.
https://quarto.org
Other
3.58k stars 294 forks source link

`table-striped` is invisible in `darkly` HTML theme #10085

Open paddyroddy opened 2 weeks ago

paddyroddy commented 2 weeks ago

Bug description

Perhaps I was expecting too much, and have verified it works in the default theme. I am using darkly and the striped visually appears to have no effect.

Steps to reproduce

_quarto.yml

---
project:
  type: website

format:
  html:
    theme: darkly

index.qmd

---
format: html
listing:
  contents: .
  table-striped: true
  type: table
---

a.qmd

---
title: A
format: html
---

b.qmd

---
title: B
format: html
---

Expected behavior

I would expect alternating black and some shade of grey perhaps?

Actual behavior

All rows appear essentially the same - works in default theme

Your environment

No response

Quarto check output

Quarto 1.4.555
[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.11: OK
      Dart Sass version 1.69.5: OK
      Deno version 1.37.2: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.4.555
      Path: /Applications/quarto/bin

[✓] Checking tools....................OK
      TinyTeX: (not installed)
      Chromium: (not installed)

[✓] Checking LaTeX....................OK
      Using: Installation From Path
      Path: /Users/paddy/texlive/2024/bin/universal-darwin
      Version: 2024

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.12.4
      Path: /Users/paddy/arc/misc/python-tooling/.venv/bin/python3
      Jupyter: (None)

      Jupyter is not available in this Python installation.
      Install with python3 -m pip install jupyter

[✓] Checking R installation...........OK
      Version: 4.4.1
      Path: /opt/homebrew/Cellar/r/4.4.1/lib/R
      LibPaths:
        - /opt/homebrew/lib/R/4.4/site-library
        - /opt/homebrew/Cellar/r/4.4.1/lib/R/library
      knitr: 1.47
      rmarkdown: 2.27

[✓] Checking Knitr engine render......OK
cscheid commented 2 weeks ago

The class is still added to the listing (that part of the code is not aware of themes), so it must be the case that the .table-striped class isn't being handled correctly in dark themes. I haven't checked but I guess it adds a background color like rgba(0,0,0,0.1) to half the rows, and if the background is dark, this is either invisible or hard to see.

paddyroddy commented 2 weeks ago

The class is still added to the listing (that part of the code is not aware of themes), so it must be the case that the .table-striped. I haven't checked but I guess it adds a background color like rgba(0,0,0,0.1) to half the rows, and if the background is dark, this is either invisible or hard to see.

Yeah, I think it might be there. But so hard to tell.