MacOS keyboard shortcuts hardcoded and no Windows

[mcanouil]

What would you like to do?

Report an issue on quarto.org

Description

See the page at https://quarto.org/docs/visual-editor/options.html and more generally all "visual editor" pages. They are all have hardcoded MacOS keyboard shortcuts (without mentioning those are macOS only) and there are no traces of the Windows version

[cderv]

Can you share a screenshot of what you are referring too exactly ?

AFAIK, we have a website that will adapt on the OS that is viewing the doc. Basically, we do replace some content of kbd elements when website is viewed not on Mac.

So you are probably looking at the mac view of the page.

Here is what I see

Not all correct, but probably different from what you see.

I bet the kbd shortcode was not available when this doc was written, we could probably update to make use of it (unless shortcode in Markdown tables does not play nicely maybe.

Anyhow,

• Doc needs to be improve to mac sure all Mac specific key are replaced (not just ⌘)
• We don't have a Windows and Mac shortcode on same page, but dynamically adapt on page load

Also I see this is related to this discussion probably

• https://github.com/quarto-dev/quarto-cli/discussions/10430

[cderv]

Also a note that we have the same logic across the website, where this part uses also for example <kbd> element directly https://quarto.org/docs/get-started/computations/vscode.html#cell-execution

Same fixes needed

[mcanouil]

@cderv ^ is symbol on macOS (also control). No Windows user can know that it's actually ctrl. And you still have the ⌥ (option) macOS symbol which does not exist on Windows.

Right now, the shortcuts are really confusing and not really useful I must say. The "conversion" logic is not great here as it leads to wrong shortcuts not usable by Windows users (and UNIX users).

[mcanouil]

FYI, on macOS:

I think having both Windows/Mac shortcuts as columns with no dynamic changes would offer a better user experience.

[cderv]

This dynamic change is the way our kbd shortcode is working on format supporting Javascript. I am not sure we want to change that, and I think kbd shortcode could be used here. Which would be coherent with other places we use it.

Though for table we could do an exception, but I can understand why only one is needed - for example, as a Windows user, I really don't need to know Mac keyboard shortcut.

[mcanouil]

While we are discussing this. Is there a way to make the visual editor shortcuts table depends on the visual editor. Maybe some kind of reference page.

For instance, are we sure all the shortcuts are the current/right ones?