search

quarto-dev / quarto-cli

Open-source scientific and technical publishing system built on Pandoc.
https://quarto.org
Other
4k stars 329 forks source link

v2 Google Fonts API? #22

Open apreshill opened 3 years ago

apreshill commented 3 years ago

It looks like the embedded bootswatch themes currently use the v1 Google Fonts API that doesn't support variable fonts:

https://github.com/quarto-dev/quarto-cli/blob/a14f4b3090178f8e01f17e28a9e93d3f5b269065/src/resources/formats/html/bootstrap/themes/sketchy.scss#L169

It doesn't seem to impact behavior of themes now, but something to be aware of is the v2 Google Fonts API uses a different base URL, see: https://developers.google.com/fonts/docs/css2

jjallaire commented 3 years ago

Interesting! Hopefully they will change that (or we could certainly also modify the bootswatch themes ourselves to do this).

apreshill commented 3 years ago

I know with pagedown I received this error using the old import API (which is how I discovered the change!)

  Failed to generate output. Reason: Failed to open https://fonts.googleapis.com/css?family=Fira+Sans+Extra+Condensed+Mono:300,400,500 (HTTP status code: 400)
dragonstyle commented 3 years ago

I'm monitoring the themes development on their v5 branches and will keep things up to date in our tree. Before we ship it would be straightforward to make the call to modify the font references when we import them.