quarto-dev / quarto-cli

Open-source scientific and technical publishing system built on Pandoc.
https://quarto.org
Other
3.95k stars 326 forks source link

Presentation: Menu toggle via 'm' key doesn't toggle #2728

Open michaelaye opened 2 years ago

michaelaye commented 2 years ago

Bug description

I was looking at the "Quarto presentations using Reveal.js" gallery presentation.

On slide 22 it says to press 'm' to toggle the menu open and closed. However, for me it only opens when pressing 'm '. Pressing 'm' again after opening it does NOT close it.

Browser: Safari 16.0 OS: macOS 12.6 (Monterey)

Viewed slide: https://quarto.org/docs/presentations/revealjs/demo/#/easy-navigation

Checklist

michaelaye commented 2 years ago

Note that the 'b' and 'c' toggles for blackboard and notes canvas work fine.

allenmanning commented 1 year ago

Thanks for posting.

I can reproduce, you need to use [Escape] to close the menu. It seems that the docs aren't aligned with the functionality.

https://github.com/denehyg/reveal.js-menu https://quarto.org/docs/presentations/revealjs/presenting.html#navigation-menu

The plugin demo does toggle close with m so it appears this is a bug with the Quarto integration.

cderv commented 11 months ago

I don't understand why this keyboard shortcut does not get picked up when Menu is open. Only ESC allows to escape from menu using Keyboard.

It seems to be registered the right way - investigation leads me to no idea on how to fix that 🤔

We'll come back to this later.