Open fuhrmanator opened 1 year ago
Thanks for the report
In the faulty themes, it seems the "background" code is not properly grayed out (so the highlighted code appears to stand out).
Yes in those theme that does not work the background color is set to transparent. As the highlighting of lines rely on changing the opacity level, it does not work for those themes. Example of rule with transparent.
.reveal pre.sourceCode code {
background-color: transparent;
padding: 6px 9px;
max-height: 500px;
white-space: pre;
}
It is possibly a revealjs theme issue indeed as we use the theme CSS value for there. I'll check that out.
It seems it comes from us setting code block bg to transparent for those themes only
https://github.com/quarto-dev/quarto-cli/blob/b36d574fafc53d3ae9f4a1c246cc2cb48bf3e2a0/src/resources/formats/revealjs/themes/sky.scss#L23 https://github.com/quarto-dev/quarto-cli/blob/b36d574fafc53d3ae9f4a1c246cc2cb48bf3e2a0/src/resources/formats/revealjs/themes/beige.scss#L26 https://github.com/quarto-dev/quarto-cli/blob/b36d574fafc53d3ae9f4a1c246cc2cb48bf3e2a0/src/resources/formats/revealjs/themes/league.scss#L28
It conflicts with our implementation of line number highlight that is suppose to work with Pandoc's syntax highlighting.
I need to check why this is needed.
Bug description
Some RevealJS themes (beige, league, sky) don't support animation of code line number highlighting per https://quarto.org/docs/presentations/revealjs/#line-highlighting (see the example where one can advance with space-bar to show highlighted lines). In the faulty themes, it seems the "background" code is not properly grayed out (so the highlighted code appears to stand out).
Here's a MWE for the problem: