quarto-dev / quarto-cli

Open-source scientific and technical publishing system built on Pandoc.
https://quarto.org
Other
3.76k stars 306 forks source link

Option to disable default image functionality #5251

Closed seeM closed 9 months ago

seeM commented 1 year ago

Apologies if I'm missing something, but there doesn't seem to be a way to disable Quarto from setting the image of a post to the first image. I was thinking of something like setting image: null in the post metadata.

cderv commented 1 year ago

If you are referring to social preview, same as your question in Discussion, you can configure this in some settings https://quarto.org/docs/reference/projects/websites.html#social

If you are referring to listing feature, we have some information at https://quarto.org/docs/websites/website-listings.html#listing-fields to change the image

Or do you want no image at all ?

seeM commented 1 year ago

Yes, I would like no image at all

cderv commented 1 year ago

Yes, I would like no image at all

No image at all where ? in a Listing page ? In social preview ?

seeM commented 1 year ago

No image in the listing and social preview.

On Thu, 20 Apr 2023 at 13:31, Christophe Dervieux @.***> wrote:

Yes, I would like no image at all

No image at all where ? in a Listing page ? In social preview ?

— Reply to this email directly, view it on GitHub https://github.com/quarto-dev/quarto-cli/issues/5251#issuecomment-1516172023, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEISACFD5ZPTHOQPXRHMLDXCENCHANCNFSM6AAAAAAXFKEQVM . You are receiving this because you authored the thread.Message ID: @.***>

dragonstyle commented 1 year ago

Right now I don't think there is a way to disable this - the auto discovery is always finding an image.

We have a couple of options:

seeM commented 1 year ago

Thanks @dragonstyle! I agree on the image: false option. I don't think it's worth rolling back the auto-discovery feature just for this option

nsfinkelstein commented 7 months ago

Using the image: false option has produced the following error for me, under Quarto version 1.4.549

ERROR: TypeError: path.startsWith is not a function

Stack trace:
    at listingItemHref (file:///opt/quarto/bin/quarto.js:89130:37)
    at listItemFromFile (file:///opt/quarto/bin/quarto.js:88951:71)
    at eventLoopTick (ext:core/01_core.js:183:11)
    at async readContents (file:///opt/quarto/bin/quarto.js:88780:34)
    at async readListings (file:///opt/quarto/bin/quarto.js:88416:36)
    at async listingHtmlDependencies (file:///opt/quarto/bin/quarto.js:90080:45)
    at async Object.formatExtras (file:///opt/quarto/bin/quarto.js:90400:45)
    at async runPandoc (file:///opt/quarto/bin/quarto.js:68741:63)
    at async renderPandoc (file:///opt/quarto/bin/quarto.js:70041:26)
    at async Object.onRender (file:///opt/quarto/bin/quarto.js:77261:36)

I was able to disable images in the listing by setting image-height: "0" in the listing options.

cscheid commented 7 months ago

@nsfinkelstein We need a reproducible document to test.

nsfinkelstein commented 7 months ago

Thanks for the response. I am happy with the approach of setting image-height: "0" in the listing options, so I don't mean to ask that the issue be reopened. I just wanted to share that approach with anyone else who happens upon the same error and github issues I did.

dragonstyle commented 7 months ago

I can reproduce this (image: false was initially intended to affect editing image metadata on the page, but it should work in this context too). Here's that issue:

https://github.com/quarto-dev/quarto-cli/issues/8715