Open mcanouil opened 6 months ago
I wonder if this is related to
which seems to not have been fixed by
All related to change for https://github.com/quarto-dev/quarto-cli/issues/5689 regarding sidebar and id
(as a sidebar
with a Title will have automatically an id assigned
Reminder: the breaking change in 1.4 was a sidebar with an id will only apply to the page related and not act as a global sidebar.
When there is title, we assign an id
But then we consider that a sidebar with an id is no more a global sidebar and we apply only on containtain href...
but here there is none, so the sidebar never applies
Two things here:
I wonder if we should reconsider some thoughts from @dragonstyle at
The problem is :
id
is undefined
is done several times
https://github.com/quarto-dev/quarto-cli/blob/6bf654a79f3efe237fa81f98b37e6c2699f22059/src/project/types/website/website-shared.ts#L344-L349navigation.sidebars
will be changed.sidebarForHref
, as they will consider a non global sidebarSo I really think we should rethink change for
The fix is breaking complex website so this needs so something is off. I am reopening and deal with this differently with more checks
The sidebar is not displayed if it does not include a Quarto document even-though there is content such as external links.
Originally posted by @mcanouil in https://github.com/quarto-dev/quarto-cli/issues/9153#issuecomment-2029528267