search

quartzmo / email-landing-page

Bootstrap-based, Heroku-ready, easily customizable marketing landing page that integrates with MailChimp. Simple Sinatra server app.
http://landingpages.herokuapp.com
153 stars 77 forks source link

Store mailchimp variables in environment #7

Closed ssaunier closed 10 years ago

ssaunier commented 10 years ago

Hello @quartzmo,

It is a better practice to store sensitive information like API keys in the environment rather than the code. Here you encourage people to store in git these info.

This PR introduces the ENV for storing MAILCHIMP_API_KEY and MAILCHIMP_LIST_NAME.

(On a related note, you may tell people to fork your project instead of cloning your main repo, don't you think?)

Thanks for putting together this landing page boilerplate!

quartzmo commented 10 years ago

Excellent contribuion ssaunier thanks a lot!!

quartzmo commented 10 years ago

ssaunier I also updated the readme with your suggestion to fork instead of clone. Thanks for the help.

ssaunier commented 10 years ago

Sure! Thanks for the merge :)