search

quest-bih / clinical-dashboard

https://quest-bravo.bihealth.org
GNU Affero General Public License v3.0
0 stars 2 forks source link

"Not applicable" does not update with registry toggle #47

Closed delwen closed 2 years ago

delwen commented 2 years ago

In the prospective registration plot in the One UMC page, the "Not applicable" does not update after changing the registry. For example, if you select Halle-Wittenberg, you get N/A for ClinicalTrials.gov (as expected as no CT.gov trials). But if you switch to DRKS, it still says N/A despite there being DRKS trials for that UMC.

bgcarlisle commented 2 years ago

This one was, surprisingly, working correctly

For the One UMC plot, we had chosen to display only the numbers from 2017

I have changed this to show the numbers from the latest year with any trials in it

Done! https://github.com/quest-bih/clinical-dashboard/commit/01f84bf7e64696ad58f9f8c4e3448176c370de1a

delwen commented 2 years ago

Agree it's a better solution to go with the latest available start date. I just made this slight change (added missing comma and updated comments): https://github.com/quest-bih/clinical-dashboard/commit/4130983d3a0012f2c205b181b368c7f152e2795b#diff-ee89f65a0b4e0dccabce1672d6d689b4e2b6ca51ea1e746bdda1eca94aaa6e0f

I this particular case (e.g., "Halle-Wittenberg"), we also have the issue that the prospective reg data in CT.gov is not displaying in the One UMC page (even though it is available) because in that dataset it is under the city name "Halle". Let's address this in a separate issue: https://github.com/quest-bih/clinical-dashboard/issues/42