search

quest-bih / clinical-dashboard

https://quest-bravo.bihealth.org
GNU Affero General Public License v3.0
0 stars 2 forks source link

Review of Methods page content #7

Closed delwen closed 3 years ago

delwen commented 3 years ago

I made some updates to the Methods page. Could you review the content of each metric (until line 345)? Each section reports on what is measured, how it was measured, and the limitations to consider.

No need to look at the tooltips as this will just be a condensed version of what's in the methods.

Thanks!

https://github.com/quest-bih/clinical-dashboard/blob/736346c59c73f03102e4d4e82e04d8635cc619bf/methods_page.R#L1

bgcarlisle commented 3 years ago

I'm on it!!

bgcarlisle commented 3 years ago

Okay I reviewed the Methods page and made some small edits: https://github.com/quest-bih/clinical-dashboard/commit/91d4768e68a38a53b12efa50848129f9e2be429d

If these meet with your approval, go ahead and make a PR!

delwen commented 3 years ago

Thanks for your suggestions, @bgcarlisle! Looks good to me. Will just wait for @maia-sh's comments and then make a PR!

bgcarlisle commented 3 years ago

You'll need to rebase on the main branch because I just pushed a fix for the bug with the one-UMC plots