search

quietvoid / pgen_client

Utility to control a Raspberry Pi with a PGenerator installation
GNU General Public License v3.0
12 stars 1 forks source link

A feature request #22

Open aproce opened 1 month ago

aproce commented 1 month ago

Hi, this is a great project. Thanks for making this available to the community.

If you accept feature requests, I have some for this application:

Could you please add support for the pattern insertion feature (when using the Internal Pattern Generator) which is required when taking color measurements of unstable displays like LG/Samsung/Sony OLED TVs?

There are three things needed:

  1. Pattern Insertion (Time based) with enable/disable option (like in Calman), with below settings the user can specify: Pattern Insertion Frequency (in seconds) Pattern Insertion Duration (in seconds) Patch Stimulus Level (in %)

  2. Pattern Insertion (Patch count based) with enable/disable option (like in Calman), with below settings the user can specify: Pattern Insertion Frequency (in no of patches) Pattern Insertion Duration (in seconds) Patch Stimulus Level (in %)

  3. Pre-roll patches with enable/disable option (like in ColourSpace), with below settings the user can specify: Pre-roll patchlist input (for the set of patches that need to be run before the start of profiling, and for which no readings should be taken) Patch Duration (in seconds)

There are two more (unrelated) features, which if added to pgen_client, will make it a complete profiling solution:

  1. Extra Delay (in seconds, for the delay between the display of a patch and the capture of the color measurement for that patch)

  2. When PGenerator is unavailable, if the pgen_client can interface with dogegen and/or Resolve TPG, it would be the ultimate solution.

Thanks!

quietvoid commented 1 month ago

The internal generator isn't meant for color critical work, the information displayed is very likely inaccurate. The program is best used to drive the PGenerator for DisplayCAL.

Also, there is already basic full field pattern insertion but it's done for every pattern, with specific duration and adjustable stimulus level.

When PGenerator is unavailable, if the pgen_client can interface with dogegen and/or Resolve TPG, it would be the ultimate solution.

The app is specifically for PGenerator, so this won't be done.

aproce commented 1 month ago

The internal generator isn't meant for color critical work, the information displayed is very likely inaccurate. The program is best used to drive the PGenerator for DisplayCAL.

The graphs etc. may be inaccurate, but the readings (being captured by spotread) would be correct, right?

So, this application can be used for color measurement data analysis and comparison of readings across different applications. Correct?

Also, there is already basic full field pattern insertion but it's done for every pattern, with specific duration and adjustable stimulus level.

Oh, I missed that as this info is missing from the description and the two pics in the Readme (or maybe I couldn't see it).

So, 2. in my requests is already done.

It would be great if 1., 3. and 4. could also be considered. Thanks!

The app is specifically for PGenerator, so this won't be done.

Hmm, ok.

quietvoid commented 1 month ago

The graphs etc. may be inaccurate, but the readings (being captured by spotread) would be correct, right?

The readings may be processed further to convert from XYZ to the expected target, so it's still possible for it to be wrong.

So, this application can be used for color measurement data analysis and comparison of readings across different applications. Correct?

I suppose if you can spare some room for error, it's not 100% correct.

aproce commented 1 month ago

Oh, ok.