Integ ink

[kimtang]

I have added ink (https://github.com/JunoLab/atom-ink) and vega (https://vega.github.io/) support for this atom package. Would be happy to see this merged into master.

[quintanar401]

Thanks for your pull request. Ink seems to be a good feature but it looks like it is much more powerful and actually can replace my Result View entirely. Have you considered adding Ink console instead of the view (via a config param of course)? Not sure though if it can accommodate large tables...

As for vega - it seems to be out of scope of this package. I'd suggest to make a plugin from it then those who need it would turn it on (it will be possible to reuse it in other places too, ink console, panes and etc). I was going to do something like this with atom-charts package. It is quite easy, if you are unfamiliar with atom packages I can help.

[kimtang]

Have you considered adding Ink console

Ink console is good but it looks like that the project itself is not maintained for a long time. So switching to ink console might be a risk.

I'd suggest to make a plugin

Sounds good to me. Unfortunately I do not know how to do it. Need time to investigate then.

Kim

From: quintanar401 [mailto:notifications@github.com] Sent: 23 March 2017 21:08 To: quintanar401/connect-kdb-q connect-kdb-q@noreply.github.com Cc: Kim Tang kuentang@vodafone.de; Author author@noreply.github.com Subject: Re: [quintanar401/connect-kdb-q] Integ ink (#10)

Thanks for your pull request. Ink seems to be a good feature but it looks like it is much more powerful and actually can replace my Result View entirely. Have you considered adding Ink console instead of the view (via a config param of course)? Not sure though if it can accommodate large tables...

As for vega - it seems to be out of scope of this package. I'd suggest to make a plugin from it then those who need it would turn it on (it will be possible to reuse it in other places too, ink console, panes and etc). I was going to do something like this with atom-charts package. It is quite easy, if you are unfamiliar with atom packages I can help.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/quintanar401/connect-kdb-q/pull/10#issuecomment-288860411 , or mute the thread https://github.com/notifications/unsubscribe-auth/AA-R_OizG-16LK1_J5UMqf0MliHY2_l-ks5rot9KgaJpZM4Ml7Ux . https://github.com/notifications/beacon/AA-R_M8J7xKE_5uLOPGcvCAnevMOSrt_ks5rot9KgaJpZM4Ml7Ux.gif

[quintanar401]

I can add kdb-chart to git, it was basically ready, you can either clone it or copy the required parts.

Also atom has a command to create a new package, you may use it directly.

[kimtang]

Yes please. I will just extend it with vega and ink

Sent from my iPhone

On 4 Apr 2017, at 20:41, quintanar401 notifications@github.com wrote:

I can add kdb-chart to git, it was basically ready, you can either clone it or copy the required parts.

Also atom has a command to create a new package, you may use it directly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[quintanar401]

added (atom-charts), may add you as a developer.

ink can be merged with connect-kdb, just remove vega from this request

[quintanar401]

keep toJSON here too

[kimtang]

As discussed with quintanar401 I will resend a pulll request with vega remove