search

quintanar401 / connect-kdb-q

Query execution support for KDB-Q in Atom
MIT License
7 stars 5 forks source link

Query Results not scrollable after updating to Atom 1.19 #15

Closed joel23888 closed 6 years ago

joel23888 commented 6 years ago

I am running Windows 7 64-bit. Atom automatically updated from 1.18 to 1.19 today. In Atom 1.19 when I ran a query on kdb the result returns as normal but Query Results is not scrollable with the mouse or the keyboard. When I reverted to Atom 1.18 it returned to being scrollable.

EdrinP commented 6 years ago

Having the same issue. Likely due to changes mentioned in #14

EdrinP commented 6 years ago

Possibly related issue: The Connect to a Server text box won't accept Enter key.

quintanar401 commented 6 years ago

No, it is something else. Can't figure it out right away. One issue - you can't set the font size on the view as before...

quintanar401 commented 6 years ago

Well, it is not my bug I think. Again buildTextEditor() function is broken somehow - I have the same issue when I just add a new editor to a new pane without any modifications.

joel23888 commented 6 years ago

I am only seeing this issue in Query Results, not in other editor tabs. I would add I can get the cursor to move around normally in Query Results, as indicated by the cursor position coordinates. The issue is just the pane not scrolling with it. I have rolled back to the previous version of Atom in the meantime.

quintanar401 commented 6 years ago

Yes, this

atom.workspace.getActivePane().addItem(atom.workspace.buildTextEditor())

leads to the same result so there is something wrong with this func.

joel23888 commented 6 years ago

I am guessing that this is probably a regression linked to the re-implementation of textBuffer referred to in #14. Not really my area of expertise but I think it might still need some change in connect-kdb-q to support the new implementation.

quintanar401 commented 6 years ago

Fixed it. It requires autoHight: false in buildTextEditor. Fonts are fixed as well - need to call a recalc of dimensions.

Keyboard issue is unrelated to 1.19 but it is fixed too. Down arrow will always work now.

joel23888 commented 6 years ago

Thanks, working for me in 1.19.