search

quintanar401 / connect-kdb-q

Query execution support for KDB-Q in Atom
MIT License
7 stars 5 forks source link

Query Results editor broken with Atom 1.11.0 update #5

Closed EdrinP closed 7 years ago

EdrinP commented 7 years ago

After Atom 1.11.0 update (and also 1.11.1), upon executing a query the bottom pane is split but the Query Results editor itself is not visible.

quintanar401 commented 7 years ago

Yes, they considerably changed the way the new editors should be created - not possible to use workspace.buildTextEditor and then add this editor to a pane. I've managed to fix it I think. Please check.

EdrinP commented 7 years ago

Your fix is working, thanks for the quick resolution!

quintanar401 commented 7 years ago

It is actually atom's bug, I'll revert back when it is fixed.

EdrinP commented 7 years ago

Looks like 1.11.2 has fixed this, feel free to revert your changes