search

quipucords / camayoc

Test automation framework that facilitates functional testing of quipucords.
https://camayoc.readthedocs.io/
GNU General Public License v3.0
5 stars 4 forks source link

Issues/336 #339

Closed himmAllRight closed 4 years ago

himmAllRight commented 4 years ago

This PR applies changes to fix the CLI and API tests that are failing due to the sshkeyfile not being defined using the container's path. Since moving to using the installer for test setup, these tests haven't worked due to them using a path-name on the host.

This fix utilizes some temporary changes to isolated_filesystem to switch the location of the temporary files to a location defined in the camayoc config. In this instance, the sshkeys directory of the container's mounted volume. Tests which create/use credentials that include ssh keyfiles were also updated to provide the qpc commands the proper path: relative to the container, and containing the correctly temp_dir and filenames generated by uuid4.

This fix is likely the first step towards a more permanent solution. While this fixes the problem, it would be clean to have isolated_filesystem default to a normal temp location, and optionally switch to the sshkeys mounted volume for tests which require it. (See Camayoc Issue #338).

Closes #336

codecov[bot] commented 4 years ago

Codecov Report

Merging #339 into master will decrease coverage by 0.74%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #339      +/-   ##
=========================================
- Coverage   76.35%   75.6%   -0.75%     
=========================================
  Files           5       5              
  Lines         203     205       +2     
=========================================
  Hits          155     155              
- Misses         48      50       +2
Impacted Files Coverage Δ
camayoc/utils.py 65.95% <0%> (-2.94%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4f8e89...ea3d08a. Read the comment docs.