After careful consideration I've come to the conclusion that the Camayoc is the right place for this playbook/test. If I place this on Camayoc I can take advantage of the already obligatory config.yaml to place my config variables such as token and server info instead of prompting the user for them. Camayoc does already most of the cli tasks I would need to do, so placing it here would also avoid code duplication.
Observations:
I gave up using ocp modules for Ansible since most of them are deprecated. People are using community.k8s nowadays, but using shell instead gave me more freedom.
To run this playbook successfully the user must have the oc installed in his computer. I didn't find where I should add this observation. Could you help me with this @ruda ?
I discarded the Molecule tests for this. This playbook usually runs in around 2 seconds. Tests were taking almost 3 minutes to complete.
I will follow this PR with another that adds a test which will verify the details report for the existence of the discovery app I deployed. After we remodel ocp we can improve the test.
ruda
commented
1 year ago
After careful consideration I've come to the conclusion that the Camayoc is the right place for this playbook/test. If I place this on Camayoc I can take advantage of the already obligatory config.yaml to place my config variables such as token and server info instead of prompting the user for them. Camayoc does already most of the cli tasks I would need to do, so placing it here would also avoid code duplication. Observations:
I will follow this PR with another that adds a test which will verify the details report for the existence of the discovery app I deployed. After we remodel ocp we can improve the test.