Closed bruno-fs closed 1 year ago
Merging #397 (122e8cc) into master (1ad7f2e) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #397 +/- ##
=======================================
Coverage 80.73% 80.73%
=======================================
Files 5 5
Lines 244 244
=======================================
Hits 197 197
Misses 47 47
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
All CLI tests passing against current quipucords 1.2.x and latest qpc
pytest -ra camayoc/tests/qpc/cli
...
================================================================================== short test summary info ==================================================================================
SKIPPED [1] camayoc/tests/qpc/cli/test_scanjobs.py:99: Skipped until Quipucords Issue #2038 us resolved
SKIPPED [1] camayoc/tests/qpc/cli/test_scanjobs.py:216: Skipping until Quipucords Issue #2040 resoloved
SKIPPED [1] camayoc/tests/qpc/cli/test_scanjobs.py:280: Skipping until Quipucords Issue #2040 resoloved
================================================================== 292 passed, 3 skipped, 6 warnings in 1271.16s (0:21:11) ==================================================================
configuration file used: https://url.corp.redhat.com/83ec367
I ran the CLI tests against a remote Discovery 1.2 server, looks good with expected failures regarding the SSH key!
=================================================== short test summary info ====================================================
SKIPPED [1] camayoc/tests/qpc/cli/test_scanjobs.py:99: Skipped until Quipucords Issue #2038 us resolved
SKIPPED [1] camayoc/tests/qpc/cli/test_scanjobs.py:216: Skipping until Quipucords Issue #2040 resoloved
SKIPPED [1] camayoc/tests/qpc/cli/test_scanjobs.py:280: Skipping until Quipucords Issue #2040 resoloved
FAILED camayoc/tests/qpc/cli/test_credentials.py::test_add_with_username_sshkeyfile - pexpect.exceptions.EOF: End Of File (EOF). Empty string style platform.
FAILED camayoc/tests/qpc/cli/test_credentials.py::test_add_with_username_sshkeyfile_become_password - pexpect.exceptions.EOF: End Of File (EOF). Empty string style platform.
FAILED camayoc/tests/qpc/cli/test_credentials.py::test_edit_sshkeyfile - pexpect.exceptions.EOF: End Of File (EOF). Empty string style platform.
FAILED camayoc/tests/qpc/cli/test_credentials.py::test_edit_sshkeyfile_negative - pexpect.exceptions.EOF: End Of File (EOF). Empty string style platform.
============================== 4 failed, 288 passed, 3 skipped, 6 warnings in 1803.11s (0:30:03) ===============================
With the changes proposed here, all CLI tests will pass as long the setting for executable is set to
qpc -v
.Also requires changes proposed on quipucords/qpc#230 and quipucords/quipucords#2331
NOTE: we should choose between this, #394 or #398