search

quipucords / camayoc

Test automation framework that facilitates functional testing of quipucords.
https://camayoc.readthedocs.io/
GNU General Public License v3.0
5 stars 4 forks source link

Port API SSH key credential tests to DataProvider #407

Closed mirekdlugosz closed 1 year ago

mirekdlugosz commented 1 year ago

There are few commits, broken down logically:

40bdfd5925c24620e86fdc103b388cde04a6c5ec is the most important one. It ports all API tests that use SSH key credential to DataProvider. As a result, these tests are passing :tada: When running against Discovery 1.2 or quipucords master, all API tests are passing or skipped (skips are DISCOVERY-293 and DISCOVERY-294). See https://url.corp.redhat.com/ibutsu-runs-d9b7a3c7-6064-44d6-b2eb-e342249f5ffa

12b55cf0f20f7107f60e48a9bdf7c826ea69f5d2 introduces DataProvider to other tests in files modified by previous commit. This is not strictly necessary, but provides consistency.

d8ce9d21e4d85d589fccb86351dbc54c28a3b2bb and 44f3496f47094024f9873644ca67a0a94739dff9 are minor fixes in data provider and settings. These issues became apparent as I was working on other things here.

I would ask to not squash commits during merge, so this logical division is still visible after merge.

codecov[bot] commented 1 year ago

Codecov Report

Merging #407 (12b55cf) into master (1d6c055) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   81.22%   81.22%           
=======================================
  Files           5        5           
  Lines         245      245           
=======================================
  Hits          199      199           
  Misses         46       46

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more