quipucords / camayoc

Test automation framework that facilitates functional testing of quipucords.
https://camayoc.readthedocs.io/
GNU General Public License v3.0
5 stars 4 forks source link

Remove outdated tests #413

Closed mirekdlugosz closed 1 year ago

mirekdlugosz commented 1 year ago

Disable optional products and Enable extended product search tests assumed that certain facts will or will not be present in report. This was true when tests were written in 2018, but changed in 2019 - now all facts are always reported. Depending on these settings, certain tasks can still be skipped, but this is only visible in server logs and can't be easily asserted in Camayoc.

Tests in questions were removed from API. Tests in CLI are changed to only check that reports with these settings can be created, run and completed - as this provides a little coverage for qpc.

$ pytest -s -v 'camayoc/tests/qpc/cli/test_scanjobs.py::test_scanjob_with_disabled_products' 'camayoc/tests/qpc/cli/test_scanjobs.py::test_scanjob_with_enabled_extended_products'

camayoc/tests/qpc/cli/test_scanjobs.py::test_scanjob_with_disabled_products PASSED
camayoc/tests/qpc/cli/test_scanjobs.py::test_scanjob_with_enabled_extended_products PASSED

======================================================================= 2 passed in 132.51s (0:02:12) ========================================================================
codecov[bot] commented 1 year ago

Codecov Report

Merging #413 (227264f) into main (c796c9b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   79.11%   79.11%           
=======================================
  Files           5        5           
  Lines         249      249           
=======================================
  Hits          197      197           
  Misses         52       52           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more