quipucords / camayoc

Test automation framework that facilitates functional testing of quipucords.
https://camayoc.readthedocs.io/
GNU General Public License v3.0
5 stars 4 forks source link

Updates for create-camayoc-ocp-config script #502

Closed ruda closed 5 months ago

ruda commented 5 months ago

Why are using timeout only for login?

Because oc login may prompt for input if you don't pass --insecure option and you don't have the proper certs stored. The command will display and wait for input:

The server uses a certificate signed by an unknown authority.
You can bypass the certificate check, but any data you send to the server could be intercepted by others.
Use insecure connections? (y/n): 

and this is going to block forever. So far, I don't believe the other commands prompts for input.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.79%. Comparing base (b4971fb) to head (a39b964).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #502 +/- ## ======================================= Coverage 76.79% 76.79% ======================================= Files 7 7 Lines 698 698 ======================================= Hits 536 536 Misses 162 162 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.