Closed infinitewarp closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.79%. Comparing base (
ab7bb60
) to head (38f03e3
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The CI failures above appear not to be related to my change. One of our internal test target servers has mysteriously gone offline, and that caused the test run to fail prematurely.
Nevertheless, I am closing this request because I have decided to change the aforementioned https://github.com/quipucords/quipucords/pull/2639 so that it is an internal-only change that will not add the new fields to any of the responses. We may add these fields to responses in a future "v2" API.
I believe this should fix the tests that are failing in camayoc as of https://github.com/quipucords/quipucords/pull/2639
Running locally on just the test that fails that PR:
Internal Jenkins job
discovery-standalone/86/
should use thisquipucords-pull-2639
camayoc branch with the imagequay.io/quipucords/quipucords:pr-2639
built for https://github.com/quipucords/quipucords/pull/2639.