quipucords / camayoc

Test automation framework that facilitates functional testing of quipucords.
https://camayoc.readthedocs.io/
GNU General Public License v3.0
5 stars 4 forks source link

fix: expect new `created_at` and `updated_at` fields #506

Closed infinitewarp closed 6 months ago

infinitewarp commented 6 months ago

I believe this should fix the tests that are failing in camayoc as of https://github.com/quipucords/quipucords/pull/2639

Running locally on just the test that fails that PR:

poetry run pytest --verbose camayoc/tests/qpc/cli/test_reports.py::test_deployments_report
========================================================================== test session starts ==========================================================================
platform darwin -- Python 3.11.3, pytest-7.4.4, pluggy-1.4.0 -- /Users/brasmith/Library/Caches/pypoetry/virtualenvs/camayoc-uSBjm9lI-py3.11/bin/python
cachedir: .pytest_cache
rootdir: /Users/brasmith/projects/camayoc
configfile: pyproject.toml
plugins: ibutsu-2.2.4, Faker-20.1.0, cov-4.1.0, playwright-0.4.4, base-url-2.1.0
collected 4 items

camayoc/tests/qpc/cli/test_reports.py::test_deployments_report[json-scan-job] PASSED                                                                              [ 25%]
camayoc/tests/qpc/cli/test_reports.py::test_deployments_report[csv-report] PASSED                                                                                 [ 50%]
camayoc/tests/qpc/cli/test_reports.py::test_deployments_report[csv-scan-job] PASSED                                                                               [ 75%]
camayoc/tests/qpc/cli/test_reports.py::test_deployments_report[json-report] PASSED                                                                                [100%]

===================================================================== 4 passed in 124.48s (0:02:04) =====================================================================

Internal Jenkins job discovery-standalone/86/ should use this quipucords-pull-2639 camayoc branch with the image quay.io/quipucords/quipucords:pr-2639 built for https://github.com/quipucords/quipucords/pull/2639.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.79%. Comparing base (ab7bb60) to head (38f03e3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #506 +/- ## ======================================= Coverage 76.79% 76.79% ======================================= Files 7 7 Lines 698 698 ======================================= Hits 536 536 Misses 162 162 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

infinitewarp commented 6 months ago

The CI failures above appear not to be related to my change. One of our internal test target servers has mysteriously gone offline, and that caused the test run to fail prematurely.

Nevertheless, I am closing this request because I have decided to change the aforementioned https://github.com/quipucords/quipucords/pull/2639 so that it is an internal-only change that will not add the new fields to any of the responses. We may add these fields to responses in a future "v2" API.