quipucords / camayoc

Test automation framework that facilitates functional testing of quipucords.
https://camayoc.readthedocs.io/
GNU General Public License v3.0
5 stars 4 forks source link

chore: drop support for brms #508

Closed infinitewarp closed 5 months ago

infinitewarp commented 5 months ago

As discussed in Slack (link), we can drop JBoss BRMS support immediately.

This change should merge and release around the same time as https://github.com/quipucords/quipucords/pull/2644 and https://github.com/quipucords/qpc/pull/329 and https://github.com/quipucords/quipucords-ui/pull/366

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.79%. Comparing base (1ef27ac) to head (c49ce6f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #508 +/- ## ======================================= Coverage 76.79% 76.79% ======================================= Files 7 7 Lines 698 698 ======================================= Hits 536 536 Misses 162 162 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bruno-fs commented 5 months ago

@quipucords/quality-engineers: Brad tested the changes introduced here in the following standalone job: https://stage-jenkins-csb-smqe.apps.ocp-c1.prod.psi.redhat.com/job/discovery-standalone/102/

mirekdlugosz commented 5 months ago

This PR leaves around few more references:

In all but first the reference is to decision_manager, which is why you might have missed them.

infinitewarp commented 5 months ago

I amended and force-pushed the commit to include the bits that Mirek mentioned. I'm not sure how I missed those in my first pass, but thank you for calling them out! I'll kick off another standalone CI run shortly to verify.

edit: standalone job: https://stage-jenkins-csb-smqe.apps.ocp-c1.prod.psi.redhat.com/job/discovery-standalone/103/

edit 2:

Finished: SUCCESS