codecov[bot]
commented
5 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.79%. Comparing base (
5d72499) to head (0d98384).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #509 +/- ## ======================================= Coverage 76.79% 76.79% ======================================= Files 7 7 Lines 698 698 ======================================= Hits 536 536 Misses 162 162 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is Camayoc counterpart work for https://github.com/quipucords/quipucords-ui/pull/349 (updating old UI to PatternFly 5). If we release new UI version before this is merged, pipelines will break.
Commit 14fe8367998cbdc4065672d4c324444f58c01bff introduces changes needed for Camayoc to work with PatternFly 5, but at the expense of PatternFly 4 (i.e. on that commit Camayoc will pass against unreleased UI, but will fail when run against older UI versions).
Commit 522cebf7e7022f31d7f5c532e2191726454bca8d changes it further in a way that Camayoc can work against either PatternFly 4 or 5. Possibly it will also work against future versions of PatternFly.
I send this as 2 commits so we can discuss the best way to move forward. We can squash both commits and have Camayoc working against both older and newer PatternFly in UI. Or we can drop second commit and have Camayoc working only against PatternFly 5. In that case, we need to coordinate merge of that PR with UI version tagging.