quipucords / camayoc

Test automation framework that facilitates functional testing of quipucords.
https://camayoc.readthedocs.io/
GNU General Public License v3.0
5 stars 4 forks source link

Change CLI tests to use client_cmd instead of client_cmd_name #513

Closed ruda closed 4 months ago

ruda commented 5 months ago

Note: this is an alternative to PR #512 . This MR just change the tests and nothing more than this.

Camayoc has two places to get the discovery cli command,

camayoc/utils.py:client_cmd = settings.quipucords_cli.executable
camayoc/utils.py:client_cmd_name = settings.quipucords_cli.display_name

Some of CLI tests for sources and scans are using client_cmd_name and unfortunally if you set Camayoc to use 'dsc' for the CLI, then client_cmd sets to dsc and client_cmd_name takes the default value 'qpc'. This setup will make the tests to fail.

Let's use client_cmd like any other CLI tests do.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.02%. Comparing base (75e944b) to head (b1b86a4). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #513 +/- ## ========================================== + Coverage 76.79% 77.02% +0.23% ========================================== Files 7 7 Lines 698 705 +7 ========================================== + Hits 536 543 +7 Misses 162 162 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.