Closed mirekdlugosz closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.42%. Comparing base (
bdb06e0
) to head (d6a47a6
).:exclamation: Current head d6a47a6 differs from pull request most recent head cdbb3a1
Please upload reports for the commit cdbb3a1 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
While working on #523, I found new tests are failing because some other tests are removing data. Since
DataProvider.cleanup()
may remove cache, there's no reason forScanContainer
to keep it.This protects a tests run against a following scenario:
scans
fixturedata_provider.cleanup()
scans
- data is removed anddata_provider
removed references, butScanContainer
is not aware of thatUnfortunately, a number of tests remove data using things like
qpc clear --all
, without ever informing DataProvider. So this is not a solution for general problem of test framework getting out of sync with data actually stored in the server.In other words, this is theoretically correct thing to do, with minimal pragmatic impact.