Closed mirekdlugosz closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.90%. Comparing base (
5bb28de
) to head (8bcc417
). Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is now ready for review and merge.
Local run results against UI v2 with quipucords-ui #463:
=================================================================== short test summary info ===================================================================
FAILED camayoc/tests/qpc/ui/test_endtoend.py::test_end_to_end[chromium-middleware-testlab-network] - playwright._impl._errors.TimeoutError: Page.fill: Timeout 30000ms exceeded.
FAILED camayoc/tests/qpc/ui/test_endtoend.py::test_end_to_end[chromium-testlab-B-network] - playwright._impl._errors.TimeoutError: Page.fill: Timeout 30000ms exceeded.
FAILED camayoc/tests/qpc/ui/test_endtoend.py::test_end_to_end[chromium-testlab-A-network] - playwright._impl._errors.TimeoutError: Page.fill: Timeout 30000ms exceeded.
FAILED camayoc/tests/qpc/ui/test_credentials.py::test_create_delete_credential[chromium-SSHNetworkCredentialFormDTO] - playwright._impl._errors.TimeoutError: Page.fill: Timeout 30000ms exceeded.
===================================================== 4 failed, 22 passed, 8 skipped in 577.05s (0:09:37) =====================================================
All failing tests try to run Network scan while using SSH. That fails because UI moved from a path to SSH file to SSH file content. Adding support for that will require larger changes in framework and I would prefer to tackle it in another PR.
Changes needed in Camayoc to tun tests against UIv2.
This is being developed against https://github.com/quipucords/quipucords-ui/pull/463 , which is in draft state. The current plan is:
main
. There are going to be failures, which will be tackled in future PRs.There are multiple commits, as I try to have one commit per area of interest. We can squash later if that is desired.
How to run:
quipucords-app
. Make sure that Quipucords is using UIv2.use_uiv2
setting. Or runexport DYNACONF_camayoc__use_uiv2=True
.