quipucords / camayoc

Test automation framework that facilitates functional testing of quipucords.
https://camayoc.readthedocs.io/
GNU General Public License v3.0
5 stars 4 forks source link

Fix UI tests using network credentials with SSH key when running UIv2 #542

Closed mirekdlugosz closed 1 month ago

mirekdlugosz commented 1 month ago

Subject says it all - with that patch, UI tests that use network credentials with SSH key pass when running against UI v2. In fact, with that patch all the UI tests pass when running against UI v2.

The only new commit here is 735f6686772f40c3b2cd93d0af03b8bce388dd7d . Otherwise, it includes entirety of https://github.com/quipucords/camayoc/pull/541 . I open it as draft for now, with the plan that we merge #541 and then I will rebase that and open it for merge.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.85%. Comparing base (a7c813e) to head (5100fc6). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
camayoc/utils.py 16.66% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #542 +/- ## ========================================== - Coverage 77.90% 76.85% -1.05% ========================================== Files 7 7 Lines 688 700 +12 ========================================== + Hits 536 538 +2 - Misses 152 162 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.