Treat exceptions raised outside of notebook cells as errors

qutip / qutip-tutorials

QuTiP Tutorials

BSD 3-Clause "New" or "Revised" License

33 stars 34 forks source link

Treat exceptions raised outside of notebook cells as errors #33

Closed hodgestar closed 1 year ago

hodgestar commented 1 year ago

I opened a feature request on the nbmake repository to handle this case https://github.com/treebeardtech/nbmake/issues/77.

hodgestar commented 1 year ago

This has been fixed in nbmake 1.3.4 -- https://github.com/treebeardtech/nbmake/issues/77. We should try it out and then close this once we've confirmed it works for us.

christian512 commented 1 year ago

I can confirm that the error which we had before in one of the notebooks is now detected correctly by nbmake. I upgraded the version of nbmake in #39 and close this issue accordingly.