search

qutip / qutip-tutorials

QuTiP Tutorials
BSD 3-Clause "New" or "Revised" License
37 stars 37 forks source link

Refactored the tutorial notebook "Reproduce: Stabalizing Feedback Controls for quantum systems" for qutip version 4.6.2 #48

Open rupayan2029 opened 2 years ago

rupayan2029 commented 2 years ago

I am new to qutip and want to contribute to the project. I have opened this issue to discuss the refactoring of the notebook titled "Reproduce: Stabalizing Feedback Controls for quantum systems" written by Robert Johansson to work with qutip version 4.6.2. The same issue is raised here in the google group as well. I have made changes to the code cells of the notebook and it seems to me to be working well. Kindly review it and finally guide me on how to add this tutorial to this repository as do not want to violate any rules here unwittingly.

PS: Below is the .md version of the notebook. Reproduce_ Stabilizing Feedback Controls for quantum systems.md

christian512 commented 2 years ago

Hey @rupayan2029, thanks for contributing to this repository. As this repository is relatively new, the contribution guidelines still need some work (I will work on this soon!).

I ran the notebook you attached with the latest release of QuTiP (4.7) and there occurs an error in the cell that calls the function general_stochastic(). For this repository, the notebook should work with the latest version of QuTiP. It would be great, if you could change the notebook to work with QuTiP 4.7 instead of version 4.6.

I can also guide you through the process of adding a notebook to the repository. For that, you can consider creating a (draft) Pull Request, so I can review your code directly. I appreciate your willingness to contribute to this repository and you don't have to be scared of violating any rules.

rupayan2029 commented 2 years ago

Sorry for responding late. I have changed the notebook to work with QuTiP 4.7 and resolved the error that was occurring in the cell containing general_stochastic(). Kindly have a look.

Thanks for appreciating contribution from amatuer quantum control enthusiast. I don't know this is the right platform, I am also looking for a masters/PhD position in Quantum control but don't have anyone who would recommend me as I am mostly self-taught. Any general advice as well as information regarding same would also be helpful.

Reproduce_ Stabilizing Feedback Controls for quantum systems.md