qutip / qutip-tutorials

QuTiP Tutorials
BSD 3-Clause "New" or "Revised" License
32 stars 34 forks source link

fixing equation rendering in 016_smesolve-inefficient-detection.md #81

Closed LegionAtol closed 4 months ago

LegionAtol commented 4 months ago
image
LegionAtol commented 4 months ago

am I missing something?

Ericgig commented 4 months ago

@LegionAtol Thank you for the contribution. No, there is probably nothing missing. All our tests / actions for qutip-tutorials have been failing and no one had/took the time to fix them. So the check are failing for an unrelated reason, but we want them to pass before accepting new contributions.

Ericgig commented 4 months ago

@LegionAtol Could you merge the main branch in to rerun the tests? They should be fixed.

LegionAtol commented 4 months ago

I tried with: git pull git push origin main --force but nothing happens, it tells me "Everything up-to-date" (because rightly no file has been changed) how can I do?

Thank you

Ericgig commented 4 months ago

Since you are working in your main branch, you could probably use sync fork on github, but it probably don't expect you to have pushed changes to your main branch.

To do it manually, you need to pull from the main branch of this repo:

git remote add upstream https://github.com/qutip/qutip-tutorials.git
git pull upstream main
git push origin main
LegionAtol commented 4 months ago

Thanks for the help I pressed the Sync button and it seems like testing has started now

LegionAtol commented 4 months ago

the problem is that if we use a single $ at the beginning and end, the equation doesn't render well on the screen:

Screenshot 2024-03-03 alle 23 22 16
Ericgig commented 4 months ago

I have a similar issue with $$: image

The issue seems to be that the equations should be on one line.

LegionAtol commented 4 months ago

thanks, actually it was enough to put it on a line. Now it's displayed like this, I think it's correct:

image