Rename all functions to use "_" instead of "."

r-hyperspec / hySpc.read.txt

Import ASCII formatted data into hyperSpec

https://r-hyperspec.github.io/hySpc.read.txt/

MIT License

0 stars 1 forks source link

Rename all functions to use "_" instead of "." #12

Closed GegznaV closed 4 years ago

GegznaV commented 4 years ago

Rename all the functions like read.txt.Witec() into read_txt_Witec(). In particular, function names should be the same as filenames that contain those functions, e.g., in https://github.com/r-hyperspec/hySpc.read.Witec/blob/develop/R/read_txt_Witec.R https://github.com/r-hyperspec/hySpc.read.Witec/blob/16a57f09b1c149e43d3f31d9284f740bc808e825/R/read_txt_Witec.R#L24

There are several not renamed functions including read.mat.Witec(), read.dat.Witec(), and read.txt.Witec().

eoduniyi commented 4 years ago

Created the branch feature-12-rename.2_ to take care of this issue

bryanhanson commented 4 years ago

@cbeleites @eoduniyi has completed this issue but I was wondering if this change requires some kind of deprecation. If no, please close this issue.

GegznaV commented 4 years ago

For exported functions only, these changes should be mentioned in NEWS.md in hyperSpec repo.

GegznaV commented 4 years ago

And when issue cbeleites/hyperSpec#263 is solved, I'll add proper deprecation messages to relevant functions in hyperSpec (as I did with hySpc.ggplot2).

eoduniyi commented 4 years ago

PR #26 closes this issue