search

r-hyperspec / hySpc.read.txt

Import ASCII formatted data into hyperSpec
https://r-hyperspec.github.io/hySpc.read.txt/
MIT License
0 stars 1 forks source link

Items from hyperSpec that should be dealt with here #21

Closed bryanhanson closed 4 years ago

bryanhanson commented 4 years ago

As far as I can see, the following issues present in hyperSpec should be addressed here at this time.

Please close over there as you tick them off.

cbeleites commented 4 years ago

hyperSpec's cbeleites/hyperSpec#38 needs to be looked into here, but the other import functions need to be checked as well. So @eoduniyi , please tick off here after checking the text import functions but leave it open in the hyperSpec repo (maybe comment there which ones are done/still need checking).

As for cbeleites/hyperSpec#174 I'm working on that in branch feature/more-unittest-data. @eoduniyi , if you want to work on that, it is right now probably easiest if you dig into unit test for the other text/ASCII import functions that you copied from hyperSpec.

eoduniyi commented 4 years ago

Okay, on it!

eoduniyi commented 4 years ago

The check_con function takes care of hyperSpec issue 38 for hySpc.read.txt the remaining hyperSpec issues on the todo list have been taken care of...