No warning in unit test

r-hyperspec / hySpc.read.txt

Import ASCII formatted data into hyperSpec

https://r-hyperspec.github.io/hySpc.read.txt/

MIT License

0 stars 1 forks source link

No warning in unit test #30

Closed GegznaV closed 4 years ago

GegznaV commented 4 years ago

For #27, I get this issue locally

cbeleites commented 4 years ago

Yes, I also found this and fixed it in 176fa7b.

GegznaV commented 4 years ago

👍

GegznaV commented 4 years ago

I ran this R-CMD check after pulling commit "Fix unit test locale". And instead 2 failed unit tests (as it was the case before pulling) only 1 was left.

Were there several commits with the same name?

cbeleites commented 4 years ago

No, but only one of them could be located on my linux machine. I keep finding more of them on Win (hopefully fixed now) and MacOS via the CI...

Reminds me of the chemist's saying: when god invented bulk matter, the devil added surfaces. I think encodings as well.

GegznaV commented 4 years ago

It seems, that the issue is fixed now.