Review, add and improve unit tests

r-hyperspec / hySpc.read.txt

Import ASCII formatted data into hyperSpec

https://r-hyperspec.github.io/hySpc.read.txt/

MIT License

0 stars 1 forks source link

Review, add and improve unit tests #42

Closed GegznaV closed 2 years ago

GegznaV commented 3 years ago

Review, fix, add and improve unit tests for these functions and their helpers:

[x] count_lines
[x] read_asc_Andor
[x] read_asc_PerkinElmer

[x] read_txt_Shimadzu

[x] #48
[x] #49
[x] #72
- read_txt_Horiba
- read_txt_Horiba_t
- read_txt_Horiba_xy

[LOW PRIORITY, may skip for now] #74
- read_ini

[x] #70
- read_zip_Renishaw
- read_txt_Renishaw

[x] #75
- read_dat_Witec
- read_txt_Witec
- read_txt_Witec_Graph
- read_txt_Witec_TrueMatch

[x] #73

GegznaV commented 3 years ago

In unit tests, make sure to check that the values in each hyperSpec slot (@data (non-spectra), @data$spc (spectra), @wavelength, and @label) are checked and that column names of @data and @data$spc are correct. This will let us detect discrepancies easier than just by using hash code.

GegznaV commented 3 years ago

@sangttruong, I assign this to you, as hySpc.read.txt is mentioned in your GSoC proposal. OK?

Create a separate branch for each file so that it was easier to review.

GegznaV commented 2 years ago

This is not closed yet!