search

r-hyperspec / hySpc.read.txt

Import ASCII formatted data into hyperSpec
https://r-hyperspec.github.io/hySpc.read.txt/
MIT License
0 stars 1 forks source link

Features/42-read-txt-horiba-xy #49

Closed sangttruong closed 2 years ago

sangttruong commented 3 years ago

Add unittest for read_txt_Horiba_xy() Resolve #42

GegznaV commented 3 years ago

Why are there 150+ files changed in this PR when only 1 file should be? (Most probably the files currently are in the wrong place to be reached by unit tests). I also noticed that the same trend of 150+ changed files is in the last few PRs (which makes it more difficult to review). @sangttruong, are the same files moved again and again in separate PRs? Or are these different files?

GegznaV commented 2 years ago

image

@sangttruong, Did you answer or solve @cbeleites comments like the one on the print screen above?

You can find them under the "Files changes" section (this applies to all pull requests).

image

In case of doubt about what to do, please, answer to the comments directly on GitHub and not on Slack so that every mentor could contribute to the discussion and could know what is the status of the issue.