search

r-hyperspec / hySpc.read.txt

Import ASCII formatted data into hyperSpec
https://r-hyperspec.github.io/hySpc.read.txt/
MIT License
0 stars 1 forks source link

CI failures due to incorrect setup #5

Closed GegznaV closed 4 years ago

GegznaV commented 4 years ago

CI tests fail due to incorrect settings in .github/workflows/pub_to_hySpc_pkgs.yml:

image

bryanhanson commented 4 years ago

This is an obsolete workflow. Not sure why it is there. Let me go look for the right one.

bryanhanson commented 4 years ago

The correct one is in the same directory, it is called build_check_deploy.yaml. Not sure why the one that causes the problem is there. I think @eoduniyi should take a look, since he's been working on this repo. He will have more info.

cbeleites commented 4 years ago

CI seems to work again - should this issue be closed?

GegznaV commented 4 years ago

Which pull request/commit solves this?

UPDATE: issue fixed in #6 And it seems that there is another issue related to CI:

![image](https://user-images.githubusercontent.com/12725868/88820888-96b0f580-d1ca-11ea-9d24-ce22ed556865.png)
GegznaV commented 4 years ago

I'll try to update pkgdown setup when I have time for that. Recently, there were changes in the way GitHub Actions servers behave.

bryanhanson commented 4 years ago

Depending up the branch there is a also a stale yaml. @eoduniyi can you take a look?

GegznaV commented 4 years ago

Currently dir ".github/workflows/" on develop branch contains 4 setup files:

  1. "build_check.yaml"
  2. "build_check_deploy.yaml"
  3. "pub_to_hySpc_pkgs.yml"
  4. "pkgdown.yaml"

The 4 is needed to build pkgdown website. And what are the purpose of the remaining 3? Which of them are obsolete?

The following question: Why is only the combination of 'Linux' and R-release used on GitHub Actions for R-CMD-check?

@eoduniyi, @bryanhanson

bryanhanson commented 4 years ago

build_check_deploy.yaml is the script I have worked on. It works and should not be touched. The others I will let @eoduniyi comment.

GegznaV commented 4 years ago

@eoduniyi have you looked at this issue?

eoduniyi commented 4 years ago

build_check_deploy.yaml is the script I have worked on. It works and should not be touched. The others I will let @eoduniyi comment.

On it!!!

GegznaV commented 4 years ago

@eoduniyi, when you close an issue, it would be better if this was linked to PR or commit that fixes the issue. It allows tracking what the solution was.

GegznaV commented 4 years ago

@bryanhanson did you solve this in b5a02ab?

bryanhanson commented 4 years ago

No, it was actually fixed in https://github.com/r-hyperspec/hySpc.read.txt/commit/5b3c09e736b1e64dea933d2c958c81efa007d6f6 Thanks for the reminder.