search

r-ss / foldwrap_backend

backend part of my Foldwrap project
https://foldwrap.com
0 stars 0 forks source link

services review suggestions #7

Open Sheihesinusslon opened 10 months ago

Sheihesinusslon commented 10 months ago

https://github.com/r-ss/foldwrap_backend/blob/5c4437e439ad34e534e4b05bd16d9c2818b86d4e/src/services/figma.py#L21-L25 store urls and hostname in constants/configs

the same for https://github.com/r-ss/foldwrap_backend/blob/5c4437e439ad34e534e4b05bd16d9c2818b86d4e/src/services/figma.py#L46-L50

https://github.com/r-ss/foldwrap_backend/blob/5c4437e439ad34e534e4b05bd16d9c2818b86d4e/src/services/figma.py#L96

https://github.com/r-ss/foldwrap_backend/blob/5c4437e439ad34e534e4b05bd16d9c2818b86d4e/src/services/email.py#L22

https://github.com/r-ss/foldwrap_backend/blob/5c4437e439ad34e534e4b05bd16d9c2818b86d4e/src/services/misc/utils.py#L27

Redis expiration time is also better store in config.

This is 100% sensitive :) better keep it in .env files https://github.com/r-ss/foldwrap_backend/blob/5c4437e439ad34e534e4b05bd16d9c2818b86d4e/src/services/misc/utils.py#L29