search

r0man / oauth-clj

Clojure OAuth library
95 stars 27 forks source link

Update to clj-http 0.3.0 breaks oauth.util/parse-body-params #3

Closed gregspurrier closed 12 years ago

gregspurrier commented 12 years ago

With the update to clj-http 0.0.3, when doing a post with a body, parse-body-params is throwing an exception. The problem is that (:body request) is now an instance of org.apache.http.entity.StringEntity and the code is not expecting this.

As a work around I've temporarily reverted back to 0.2.7 via my project.clj file.

r0man commented 12 years ago

Hi Greg,

thanks for the bug report. I could reproduce your problem, added a test that updates a status on twitter and verified it is running with clj-http 0.2.7. I released this as 0.0.4 and pushed it to Clojars.

I added some code to convert a StringEntity back to a string when signing the request, but something gets messed up and the "easy" fix is not working at the moment. I try to switch to clj-http > 0.2.7 when I have a little bit more time in the next weeks.

Until now, I hope you will be fine with clj-http 0.2.7 in the 0.0.4 version. Otherwise, patches welcome ...

Roman.

r0man commented 12 years ago

I close this issue and added a todo: https://github.com/r0man/oauth-clj/issues/4

gregspurrier commented 12 years ago

Thanks. I don't have a pressing need for clj-http > 0.2.7, so I'm fine for now.

r0man commented 12 years ago

Fixed in 0.0.5-SNAPSHOT.