Closed eikowagenknecht closed 1 month ago
Below, I will list the solutions for each.
bun run check in main dir:
I forgot to format and lint with biome. My apologies. It looks like we need to create a CI for formatting.
bun run build in main dir:
This is passing in CI, so it's behaving strangely. It might be fixed by deleting node_modules
in all subdirectories and running bun install
. For reference, here is the latest log from a successful CI run: https://github.com/r4ai/remark-callout/actions/runs/10027274396/job/27712699087
bun run prepare in main dir:
It seems I forgot to update this when I upgraded husky. We might need to update the prepare
command in package.json
.
readme commands:
The readme was incorrect. Instead, please run bun run test
or bun run test:ci
.
I am a bit busy now, so I might not be able to address this for 1-2 weeks. However, PRs are always welcome.
I apologize for the inconvenience, and thank you for reporting the issues.
bun run check
bun run build
bun run check
:
Biome has recently started partial support for Astro files, so it might be a good idea to migrate if possible. If it's difficult, it would be good to set up turborepo and lint-staged to use prettier and eslint only for the website.
https://biomejs.dev/internals/language-support/#html-super-languages-support
bun run build
:
If you are using Windows, it might be better to develop using WSL. I have been developing without any issues from WSL.
Unfortunately for .astro
files, currently "only the frontmatter portion of the file is supported."
For my own astro project I go with
"scripts": {
"build": "pnpm prebuild && astro check && astro build",
"format": "prettier --write .",
"lint": "tsc --noEmit && biome check --write ./src && prettier --write ./src",
},
"devDependencies": {
"@biomejs/biome": "1.8.3",
"prettier": "3.3.3",
"prettier-plugin-astro": "0.14.1",
"prettier-plugin-tailwindcss": "0.6.5",
}
I have no experience with monorepos, though.
I hope biome can one day replace everything, but it seems that's not ready yet.
It would be a good idea to use Prettier and Biome for the website, but only use Biome for the packages/remark-callout. This can be achieved by creating check
and check:write
scripts in each packages, and execute these with Turborepo (similar to how the test
script is currently executed).
I have fixed the issues as described below, so I'll close this issue. If there are any problems, please feel free to mention me.
bun run check
in the main directory:
In #141, the check
command was fixed.
bun run prepare
in the main directory:
In #140, I migrated from Husky and Lint-staged to Lefthook. As a result, you will no longer encounter Husky errors during bun install
. If Lefthook doesn't work correctly, I recommend recloning the repository and running bun install
again.
Readme commands:
In #143, the test commands were fixed.
Thank you for reporting the issues.
Thanks. Good choice going with lefthook. I use it for my projects as well.
Something seems funky with the package config (or I'm doing something wrong),
bun run check in main dir
Running
bun run check
in the main dir leads to currently 15 files of the website directory being reformatted.bun run build in main dir
bun run build
also fails for me:It also fails when I run
bun run build
in packages\website, just likebun run dev
etc. also fail.bun run prepare in main dir
Husky now uses
husky
instead of the deprecatedhusky install
readme commands
The readme mentions running
bun run test --ui
, but that seems to not exist: